Skip to content

Commit

Permalink
fix implicitly nullable via default value null
Browse files Browse the repository at this point in the history
Signed-off-by: Benjamin Brahmer <[email protected]>
  • Loading branch information
Grotax committed Feb 16, 2025
1 parent baec4c7 commit bb933e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the
# Unreleased
## [25.x.x]
### Changed
- enable support for php 8.4 (#3038)

Check failure on line 10 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'php'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'php'?", "location": {"path": "CHANGELOG.md", "range": {"start": {"line": 10, "column": 22}}}, "severity": "ERROR"}

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion lib/Service/ItemServiceV2.php
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public function read(string $userId, int $id, bool $read): Entity
*
* @return int|null Amount of deleted items or null if not applicable
*/
public function purgeOverThreshold(int $threshold = null, bool $purgeUnread = null): ?int
public function purgeOverThreshold(?int $threshold = null, ?bool $purgeUnread = null): ?int
{
$threshold = $threshold ?? $this->config->getValueInt(
Application::NAME,
Expand Down

0 comments on commit bb933e3

Please sign in to comment.