Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply theming to user mentions #4774

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

apply theming to user mentions #4774

wants to merge 13 commits into from

Conversation

sowjanyakch
Copy link
Contributor

see comment #4672 (comment)

user_mentions

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review February 28, 2025 12:01
@sowjanyakch sowjanyakch self-assigned this Feb 28, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 28, 2025
@sowjanyakch sowjanyakch changed the title theme user mentions apply theming to user mentions Feb 28, 2025
@mahibi mahibi force-pushed the mentions_colors branch from 4126bd2 to b059dcc Compare March 6, 2025 13:03
mahibi
mahibi requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from Joas/Marcel M.

@mahibi
Copy link
Collaborator

mahibi commented Mar 6, 2025

i think it crashed for me one time when entering the chat but did not find the crashlog..

@nickvergessen nickvergessen linked an issue Mar 17, 2025 that may be closed by this pull request
Color mentions when user is part of the group or team #4805
Open
@sowjanyakch sowjanyakch force-pushed the mentions_colors branch 3 times, most recently from b2020cf to 3ba5d27 Compare March 19, 2025 10:21
@sowjanyakch sowjanyakch requested a review from mahibi March 19, 2025 10:22
@sowjanyakch
add endpoints
b3b4ca8 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add model
0bfa964 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add copyright
824e357 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
theme user groups and mentions
9afb470 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
modify ncApiCoroutines
7d723ed 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
theme mention-all and remove unused code
9fa0ff7 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix group mentions
9a6965b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
store user groups and circles in room database
391d609 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add copyright
2b908bd 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
apply theming to user mentions
18443d3 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
ktlintformat
a5cf64e 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
refactor
0173bb5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
logging info
a66af64 
Signed-off-by: sowjanyakch <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4774-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9897
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222118
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@SystemKeeper SystemKeeper SystemKeeper left review comments

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@mahibi mahibi Awaiting requested review from mahibi

Requested changes must be addressed to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color mentions when user is part of the group or team
4 participants
@sowjanyakch @mahibi @nickvergessen @SystemKeeper