-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump tailwind-merge version #3657
base: canary
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1050818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change focuses on updating the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- .changeset/grumpy-mayflies-rhyme.md (1 hunks)
- packages/core/theme/package.json (1 hunks)
- packages/core/theme/src/utils/cn.ts (1 hunks)
- packages/core/theme/src/utils/tw-merge-config.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/grumpy-mayflies-rhyme.md
Additional comments not posted (3)
packages/core/theme/src/utils/tw-merge-config.ts (1)
3-3
: Consider the implications of removing explicit type annotations.The removal of the explicit type
Partial<Config>
fromtwMergeConfig
may increase flexibility by relying on TypeScript's type inference. However, this can potentially reduce type safety if the inferred type does not match the expected structure. Ensure that this change aligns with your project's type safety requirements.packages/core/theme/src/utils/cn.ts (1)
13-13
: Verify compatibility with the new configuration structure.The change to use
{extend: twMergeConfig}
inextendTailwindMerge
likely aims to provide more flexible configuration handling. Ensure that theextend
key is correctly processed by theextendTailwindMerge
function and that it aligns with the expected configuration structure.packages/core/theme/package.json (1)
60-60
: Verify compatibility of the updatedtailwind-merge
dependency.The update to
tailwind-merge
version^2.5.2
likely includes new features and bug fixes. Ensure that this version is compatible with your current codebase and does not introduce any breaking changes, especially in how class names are merged.
Closes #3614
📝 Description
tailwind-merge
is still using v1. Upgrade to v2.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
tailwind-merge
dependency to the latest version for improved styling capabilities and performance.