fix(menu): resolve dropdown selection issue

[sohan01fw]

Closes #1560

📝 Description

This PR addresses the issue where the dropdown selection functionality is not working on mobile devices as well as in web.

⛳️ Current behavior (updates)

As you can see the figure below the bug is the selection stay at the same place when cursor move out of the menu.

04.09.2024_15.24.15_REC.mp4

🚀 New behavior

As Video below the bug get solved by applying some condition in code

fix.mp4

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

Summary by CodeRabbit

• New Features

  • Enhanced menu item interactivity by modifying the conditions for selection, ensuring items are only selectable when pressed.

• Bug Fixes

  • Improved user experience by refining the logic for the data-selectable attribute.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6c5769c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@sohan01fw is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes made to the useMenuItem function in the use-menu-item.ts file modify the logic for setting the data-selectable attribute. The new implementation ensures that the attribute reflects both the isPressed and isSelectable states, enhancing the control flow of the menu item interaction.

Changes

Files	Change Summary
packages/components/menu/src/use-menu-item.ts	Modified the logic for setting the data-selectable attribute to depend on both isPressed and isSelectable.

Assessment against linked issues

Objective	Addressed	Explanation
Dropdown selection examples are not working in mobile (#1560)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 87336c7 and 6c5769c.

Files selected for processing (1)

• packages/components/menu/src/use-menu-item.ts (1 hunks)

Additional comments not posted (1)

packages/components/menu/src/use-menu-item.ts (1)

137-137: LGTM! The change enhances the menu item interactivity.

The new implementation of the data-selectable attribute ensures that the menu item is selectable only when it is pressed (isPressed is true) and selectable (isSelectable is true). This change introduces a dependency on the isPressed state, effectively modifying the control flow and the conditions under which the menu item is considered selectable.

As highlighted in the AI-generated summary, this change potentially improves the user experience in scenarios where the pressed state is significant for the menu item interaction.