Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more formats for params.input #3484

Closed
wants to merge 8 commits into from

Conversation

anoronh4
Copy link
Contributor

@anoronh4 anoronh4 commented Mar 7, 2025

Addresses #3482

Pipeline was failing when attempting to use json or other formats other than csv as the input. nf-schema is capable of handling json/tsv/yaml input files, this PR allows a template-synced pipeline to be able to take advantage of that.

Looking forward to hearing your thoughts!

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@anoronh4 anoronh4 changed the title Feature/flexible input types allow more formats for params.input Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (67146de) to head (5a6291f).
Report is 23 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anoronh4, thanks for your contribution. But I don't think this change is necessary. You can change the pattern in your pipeline to allow any kind of input file, so we don't need to add the change in the template. I would also advise avoiding the use of oneOf to avoid complications, you can create a pattern that accepts all file extensions. We will also deprecate the use of mimetype in the future, so there is no problem in removing it from the schema.

@anoronh4
Copy link
Contributor Author

anoronh4 commented Mar 10, 2025

Hi @anoronh4, thanks for your contribution. But I don't think this change is necessary. You can change the pattern in your pipeline to allow any kind of input file, so we don't need to add the change in the template. I would also advise avoiding the use of oneOf to avoid complications, you can create a pattern that accepts all file extensions. We will also deprecate the use of mimetype in the future, so there is no problem in removing it from the schema.

thanks for your feedback. personally i try to minimize the amount of changes i make to the template, because in the past i have spent a significant amount of time carefully reconciling my pipeline changes with template changes every time i sync, and thought others might benefit as well. it's not a big effort for each user in any case.

@anoronh4 anoronh4 closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants