-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow more formats for params.input #3484
Conversation
…ols into feature/flexible_input_types
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anoronh4, thanks for your contribution. But I don't think this change is necessary. You can change the pattern in your pipeline to allow any kind of input file, so we don't need to add the change in the template. I would also advise avoiding the use of oneOf
to avoid complications, you can create a pattern that accepts all file extensions. We will also deprecate the use of mimetype
in the future, so there is no problem in removing it from the schema.
thanks for your feedback. personally i try to minimize the amount of changes i make to the template, because in the past i have spent a significant amount of time carefully reconciling my pipeline changes with template changes every time i sync, and thought others might benefit as well. it's not a big effort for each user in any case. |
Addresses #3482
Pipeline was failing when attempting to use json or other formats other than csv as the input. nf-schema is capable of handling json/tsv/yaml input files, this PR allows a template-synced pipeline to be able to take advantage of that.
Looking forward to hearing your thoughts!
PR checklist
CHANGELOG.md
is updateddocs
is updated