-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple workflow in subworkflow #3486
base: dev
Are you sure you want to change the base?
Conversation
@@ -7,7 +7,6 @@ jsonschema>=4.0 | |||
markdown>=3.3 | |||
packaging | |||
pillow | |||
pdiff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing pdiff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was present twice
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
After consideration, I think it would be better to not allow the presence of mutliple process / workflow in a single file. |
I agree with this @LouisLeNezet 👍 |
PR checklist
This PR should close #3479
However when multiple workflow are present in one
main.nf
the input and output are aggregated for all. Therefore if one of the workflow does not have any input or output but the other one does, no error will be thrown.An easy fix would be to ban any file with more than one workflow (need template modification for
local/utils_nfcore_*_pipeline
CHANGELOG.md
is updateddocs
is updated