Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partials: disable automatic links for custom product pages #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Apr 2, 2025

Proposed changes

Disables the automatic list of link cards if you add custom content to the root _index.md for a product. There's an exemption here specifically for NGINX One and the solutions page. They should be converted to custom pages down the line, instead of their current setup.

I aim to remove these list and list-main partials entirely from this repository, and instead, provide the right set of partials/shortcodes/templates directly from the theme.

Should not be merged until nginxinc/nginx-hugo-theme#210 is released

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@nginx-jack nginx-jack requested a review from a team as a code owner April 2, 2025 11:16
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Apr 2, 2025
Copy link

github-actions bot commented Apr 2, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/348/

@nginx-jack
Copy link
Contributor Author

Needs some tweaks - Some empty products aren't rendering lists properly. Will update.

@nginx-jack nginx-jack force-pushed the feat-custom-product-pages branch from 52f13e5 to a60ef8d Compare April 2, 2025 13:13
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 2, 2025
@nginx-jack nginx-jack force-pushed the feat-custom-product-pages branch from a60ef8d to f5cce21 Compare April 2, 2025 14:47
@nginx-jack
Copy link
Contributor Author

Needs some tweaks - Some empty products aren't rendering lists properly. Will update.

Ready for review 👍

@lamATnginx lamATnginx marked this pull request as draft April 2, 2025 16:58
@nginx-jack nginx-jack marked this pull request as ready for review April 3, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants