Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverting keepalived changes after removing dependency in 2.19.1 #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bejjrajesh
Copy link
Contributor

Proposed changes

This MR will revert the changes introduced in the MR(#233). We have removed the keepalived dependency on the Nginx Instance Manager.

Solution:Keepalived should be installed by customer manually when setting up the NIM HA availability.

Testing: Reverting to existing working copy only.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@bejjrajesh bejjrajesh requested a review from a team as a code owner April 4, 2025 16:30
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 4, 2025
@mjang
Copy link
Contributor

mjang commented Apr 4, 2025

@bejjrajesh I should have asked this question for #233

  • In our docs, we refer to the keepalived service for high availability.
    • If I understand your intent correctly, with this PR (MR), users in disconnected environments will have to use the high availability doc (if they want HA)

For the record, I'm approving, as this seems to be a straight "revert" from PR #233. But we need to know if there's an impact to our docs.

cc @travisamartin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants