-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tech-specs.md to include NAP #68
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
✅ Deploy Preview will be available once build job completes!
|
Co-authored-by: Daniel Edgar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed my own "style-only" suggestions and approved.
I have hereby read the F5 CLA and agree to its terms |
Accepting / merging, since the requested change was also included in this PR. |
Proposed changes
There is no mention of NGINX App Protect in the tech specs for NGINX Instance Manager. NAP requires additional memory and CPU, so this needs to be mentioned,
Checklist
Before creating a PR, run through this checklist and mark each as complete.
I have read the contributing guidelines
I have signed the F5 Contributor License Agreement (CLA)
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (
README.md
andCHANGELOG.md
)I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
If the change involves:
<username>
in place of PIIIn these cases, the change will require at least two (2) approvals before merging