Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tech-specs.md to include NAP #68

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

mkingst
Copy link
Contributor

@mkingst mkingst commented Jan 15, 2025

Proposed changes

There is no mention of NGINX App Protect in the tech specs for NGINX Instance Manager. NAP requires additional memory and CPU, so this needs to be mentioned,

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mkingst mkingst requested a review from a team as a code owner January 15, 2025 10:27
Copy link

github-actions bot commented Jan 15, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/68/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed my own "style-only" suggestions and approved.

@mjang mjang requested a review from aknot242 January 24, 2025 15:31
@mkingst
Copy link
Contributor Author

mkingst commented Jan 24, 2025

I have hereby read the F5 CLA and agree to its terms

@mjang
Copy link
Contributor

mjang commented Jan 24, 2025

Accepting / merging, since the requested change was also included in this PR.

@mjang mjang merged commit f8392b3 into main Jan 24, 2025
8 checks passed
@mjang mjang deleted the mkingst-nim-nap-tech-spes branch January 24, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants