-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mkpasswd
as htpasswd generator
#134
base: main
Are you sure you want to change the base?
Conversation
Hi @tats-u , Thank you for your contribution. I would suggest concatenating the two patches into one and removing the installation options for consistency with the htpasswd / openssl passwd commands, for example, Also, please refer to our README.md for:
|
distribution or the “<command>openssl passwd</command>” command; | ||
distribution or the “<command>mkpasswd</command>” or “<command>openssl passwd</command>” command; | ||
<note> | ||
“<command>mkpasswd</command” can be installed by “<command>apt install whois</command>” in Ubuntu / Debian or “<command>dnf install mkpasswd</command>” in RHEL 9+. The command with the same name, “<command>mkpasswd</command>”, which is included in the “expect” package in RHEL8 and earlier, is a different command. It was renamed to “<command>mkpasswd-expect</command>” in RHEL 9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing the installation options for consistency with the htpasswd / openssl passwd commands, for example,
"can be generated using
the “htpasswd” utility from the Apache HTTP Server
distribution, the “mkpasswd”, or the “openssl passwd” command;"
Also, please refer to our README.md for:
the commit log style, for example: "Added mkpasswd as htpasswd generator."
a version bump of the page: rev="11"> instead of rev="10">
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean reverting 3b08b0a? I think +
and -
are swapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just mentioning the mkpasswd would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not help mentioning whois
command (mkpasswd
is derived from it) in favor of RHEL 8 users.
mkpasswd
command is the best for the Basic authentication password hash string generator for the following reasons:openssl passwd
doesn't support bcrypt or yescrypt.openssl passwd
cannot do it./etc/shadow
by default.openssl passwd
uses the stale MD5Crypt by default.mkpasswd
is included in the packagemkpasswd
(RHEL 9+) /whois
(Ubuntu).Note: that included in the
expect
package is completely different. Its command name was duplicated in RHEL 8 or prior but renamed in RHEL 9 or later or Ubuntu.