-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml introduction #1151
Conversation
FYI, here's what your build failure is about:
Poetry used to have special syntax for "dev-dependencies", but now it has more general "group" feature and "dev-dependencies" are now just a group named "dev".
This project creates a Poetry project on the fly and uses I think it's using
The latest If the Also, if the |
…ation to use pyproject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python example validation looks good.
@bkeryan I'm a bit confused: did you want my pyproject.toml changes to go in before upgrading the linux toolchain version? I assumed this PR would pull in Gabe's changes from grpc-sideband and fix the failing check. |
I asked "Is it possible to check in the Python fixes separately from the Linux toolchain update?" If you can't complete the PR because the Linux build is still broken, then I suppose the answer is "no". |
Oh...in that case, no I can't. I assume the only way around this is to combine all changes into one PR? |
I think #1155 may fix your current build failure. |
What does this Pull Request accomplish?
Changes the toolchain version pulled in, so we're now using version gcc 7+. We would've pulled the toolchain directly from the nilrt repo, but other teams faced difficulty attempting that route.
Why should this Pull Request be merged?
Events are not able to run tests, presumably failing because gcc 6.3 isn't compatable with GLIBCXX_3.4.30
What testing has been done?
None