Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable module verifier in debug builds #1889

Conversation

calda
Copy link
Collaborator

@calda calda commented Sep 26, 2024

I noticed incremental builds were taking a lot longer in Xcode 16. There's a Verify Modularization of SwiftFormat.framework step that takes 30+ seconds on every build:

Screenshot 2024-09-26 at 10 08 53 AM

I have no clue what this does, but it should be fine to disable in debug builds. With this change, incremental debug builds are back to taking a second or less.

Screenshot 2024-09-26 at 10 09 14 AM

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (a362359) to head (d833b02).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1889      +/-   ##
===========================================
+ Coverage    94.79%   94.80%   +0.01%     
===========================================
  Files          134      134              
  Lines        19018    19018              
===========================================
+ Hits         18028    18030       +2     
+ Misses         990      988       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicklockwood nicklockwood merged commit 99cfd1c into nicklockwood:develop Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants