Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in wrapMultilineStatementBraces rule from bad isStartOfClosure result #1896

Conversation

calda
Copy link
Collaborator

@calda calda commented Sep 30, 2024

This PR fixes a regression in wrapMultilineStatementBraces that appears to be caused by 71a08dd.

On develop, code like this:

extension Foo {
    public func testWithWhereClause<A, B, Outcome>(
        a: A,
        b: B)
        -> Outcome where
        Outcome == (A, B)
    {
        return (a, b)
    }
}

is currently being reformatted to:

extension Foo {
    public func testWithWhereClause<A, B, Outcome>(
        a: A,
        b: B)
        -> Outcome where
        Outcome == (A, B) {
            return (a, b)
       }
}

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (be3df7b) to head (9df2644).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
+ Coverage    94.83%   95.02%   +0.19%     
===========================================
  Files          135      135              
  Lines        19278    19274       -4     
===========================================
+ Hits         18282    18316      +34     
+ Misses         996      958      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicklockwood nicklockwood merged commit c5b089c into nicklockwood:develop Sep 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants