Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git clone requires use of --recursive to checkout submodule pyffi #209

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Git clone requires use of --recursive to checkout submodule pyffi #209

merged 1 commit into from
Jul 22, 2015

Conversation

Ghostbird
Copy link
Contributor

The install script would not run for me even after I fixed some errors in it (I'll open a separate pull request when I can test those fixes.)
I realised then that when I forked the repository I used a normal clone. However that does not download the pyffi, leaving that folder empty, whereas the install script assumes it will be cloned.

If the repo is forked with '--recursive' the pyffi submodule should be checked out recursively. (Could not verify, link seems dead, see #208)

It seemed a good idea to show that in the manual.

@neomonkeus
Copy link
Member

It already is in the manual, see blender_nif_plugin/docs/development/setup/sourcecode.rst
Here is a compiled version, github doesn't follow the markup links - http://www.niftools.org/projects/plugins/blender_nif_plugin/docs/

Yes, it should be in on the readme.

neomonkeus added a commit that referenced this pull request Jul 22, 2015
Git clone requires use of --recursive to checkout submodule pyffi
@neomonkeus neomonkeus merged commit 74660d8 into niftools:develop Jul 22, 2015
@Ghostbird Ghostbird deleted the readme-recursive-checkout branch August 26, 2015 10:26
@neomonkeus neomonkeus added Documentation Issue incorporates changes/improvements to the documentation Invalid The issue has been analysed closed off and no further work will be done on it. Improvement The issue improves on existing functionality Usability Improvement/impact to make the plugin easier to use and removed Invalid The issue has been analysed closed off and no further work will be done on it. labels May 16, 2016
@neomonkeus neomonkeus added this to the v2.6.0a0.dev4 milestone May 16, 2016
@neomonkeus neomonkeus self-assigned this May 16, 2016
TagnumElite pushed a commit to TagnumElite/blender_niftools_addon that referenced this pull request Dec 5, 2019
Git clone requires use of --recursive to checkout submodule pyffi
neomonkeus added a commit to neomonkeus/blender_nif_plugin that referenced this pull request Jan 21, 2020
Git clone requires use of --recursive to checkout submodule pyffi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issue incorporates changes/improvements to the documentation Improvement The issue improves on existing functionality Usability Improvement/impact to make the plugin easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants