-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #24
Draft
zineanteoh
wants to merge
41
commits into
main
Choose a base branch
from
testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Testing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of setting up GitHub Actions CI for Unit Testing (Jest) and E2E testing (Detox).
TL;DR
This was a pain to set up. So many errors, so little reliable documentations.
Why it's a pain:
To do component testing, the official React Native website recommends using either:
A quick look at these two options, it seems like
react-native-testing-library
(RNTL) might be easier for us to set up and use.So what happens when you do
npm install --save-dev @testing-library/react-native
?BOOM! You get an error saying there is a dependency conflict with React, React Native, and React Test Renderer.
The RNTL team anticipated this, and so they have a section specifically for this error (Note: it was not helpful, as it just points us to GitHub issues with dozens of suggested solutions with mixed of up and down votes. None of those worked for me.
In hindsight, I should've looked at the example repository earlier and explicitly install
react-test-renderer
to be the same version as react (this was the key).Ended up needing to:
npm install --save-dev [email protected]
(must be the same version as our react)npm install --save-dev @testing-library/react-native
(now it magically works!)npm install --save-dev @testing-library/jest-native
(recommended by RNTL)jest.config.ts
according to this article (we for some reason still have to usejest-expo
as our jest's preset. I honestly could not find any documentation on this whatsoever and I don't understand why we can't use, say,react-native
preset)What I learned
The struggle did not go to waste, as I did learn a few things from this:
Which returns
How to setup E2E testing with detox locally:
npm i detox-cli -g
brew tap wix/brew
brew install applesimutils
detox build --configuration ios.sim.debug
(super long)npm start
detox test --configuration ios.sim.debug
detox test --configuration ios.sim.release