-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Add STMContainers.Multiset #13
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution, however I believe it would be better for you to release this as your own separate package. Since in your implementation you only depend on the public parts of the API this should pose no problems for you. I've actually been thinking about revising the library to extract all the others containers as separate packages. If you're interested in the reasons, I've described a few in a documentation for another package. I plan to make an expanded post about the benefits of such an approach some time soon. |
Thanks for the quick response! I think you're making some pretty good points in that README. On the other hand it's only a few days ago that I heard other people favoring fewer, more fully-featured packages. I think the main argument was less maintenance hassle for both authors and users. Would you mind if I leave this PR open until the discussion on your post is over? I'd be very interested in hearing other opinions on this policy. |
Sure. I'll try to remember to post a link here when I publish it. |
Thanks!
No worries! I'm sure I'll see it on |
@nikita-volkov Did you ever write that post? ;) |
@sjakobi What ever became of this? Did you release your work as a separate package? |
I haven't so far. If you'd like to use it, I will though! Do you have a comment on the design issue from above?
|
@3noch Not yet |
I'd just like to chime in on the separate package debate. The major problem I see with releasing a package like Ideallly, there could be a prominent section in @nikita-volkov What do you think about that? Would you be willing to, say, point at other peoples' packages in the |
@sjakobi (Similar situation solved in |
Sure! No problem |
I have implemented a simple multiset on top of
Map
that is useful for counting things. The API is partly inspired by themultiset
package.I'm still unsure about the following design issue:
Should the counts be represented as
Word
,Word64
orNatural
instead?This would simplify
focus
,insertMany
anddeleteMany
, and allow for larger counts.On the downside
Word
andWord64
are slightly more hairy to use safely andNatural
would result in higher memory consumption.