Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): support custom baseURL #2966

Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix(netlify): support custom baseURL #2966

merged 2 commits into from
Jan 4, 2025

Conversation

TheAlexLichter
Copy link
Member

@TheAlexLichter TheAlexLichter commented Jan 3, 2025

πŸ”— Linked issue

Resolves #1484
(happy to backport to v2 as well)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Similar to the Vercel and CF PR, this supports the base url for the netlify presets.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Jan 3, 2025

v2 is active branch can you please rebase? πŸ™

Also have you externally verified changes?

@TheAlexLichter TheAlexLichter changed the base branch from main to v2 January 3, 2025 22:15
@TheAlexLichter TheAlexLichter requested a review from pi0 as a code owner January 3, 2025 22:15
@TheAlexLichter TheAlexLichter marked this pull request as draft January 3, 2025 22:15
@TheAlexLichter TheAlexLichter marked this pull request as ready for review January 3, 2025 22:16
@TheAlexLichter
Copy link
Member Author

TheAlexLichter commented Jan 3, 2025

Yup, verified in a quick demo (with Nuxt). Happy to open-source & link it πŸ‘πŸ»

Also, would you consider a similar change for the default static build (due to nuxt/nuxt#30446 (comment)) and the difference between building the default static vs. vendor-specific with a base url?

@pi0 pi0 changed the title fix(netlify): respect baseURL fix(netlify): support custom baseURL Jan 4, 2025
@pi0 pi0 merged commit 8b58180 into v2 Jan 4, 2025
4 checks passed
@pi0 pi0 deleted the feat-base-url-netify branch January 4, 2025 00:34
@pi0
Copy link
Member

pi0 commented Jan 4, 2025

Also, would you consider a similar change for the default static build (due to nuxt/nuxt#30446 (comment)) and the difference between building the default static vs. vendor-specific with a base url?

This would be a breaking change for static behavior at least. Depending on the deployment strategy, baseURL needs to be applied to the filesystem output or not (if the platform removes it).

Do you mind to as the first step creating a nitro-only minimal reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netlify preset support for custom baseURL
2 participants