Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese Kanon #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Japanese Kanon #3

wants to merge 11 commits into from

Conversation

mkpoli
Copy link
Contributor

@mkpoli mkpoli commented Dec 23, 2020

No description provided.

ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
japanese-kanon.js Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
ayaka14732
ayaka14732 reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@ayaka14732 ayaka14732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkpoli I like it! ❤️
I am checking the 韻母規則 now. You can fix the styling issue first.

ayaka14732
ayaka14732 reviewed Dec 24, 2020
View reviewed changes
Copy link
Member

@ayaka14732 ayaka14732 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just remember that Wiktionary differentiates 效 (カウ) and 鋼 (カゥ). Is it reasonable? Can we also add an option to differentiate that?

For reference:

  1. 漢字音表 - 字音仮名遣い
  2. 小写的假名ゥ是对鼻化元音的表记吗？这种表记方式有何缘由？ - 知乎

@mkpoli
Copy link
Contributor Author

mkpoli commented Dec 24, 2020

I have just remember that Wiktionary differentiates 效 (カウ) and 鋼 (カゥ). Is it reasonable? Can we also add an option to differentiate that?

For reference:

It may be useful but surely not a common practice. So I will make a switch for that but set to false by default.

edward-martyr added a commit that referenced this pull request Jul 5, 2022
@edward-martyr
Merge pull request #3 from edward-martyr/zaonhe_dev
3c3ce11 
勘誤
@untunt untunt force-pushed the main branch 3 times, most recently from a50f6d6 to 1769033 Compare August 20, 2022 02:18
@untunt untunt force-pushed the main branch 2 times, most recently from 6b51961 to 62b1074 Compare May 12, 2023 16:01
@graphemecluster graphemecluster mentioned this pull request Oct 14, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaka14732 ayaka14732 Awaiting requested review from ayaka14732

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkpoli @ayaka14732