Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decorated Kan-on romanization #56

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

justinsilvestre
Copy link
Contributor

Hi πŸ‘‹

I have a Middle Chinese notation system a little like ayaka's "ηΆΎι¦™ζ€θ€ƒιŸ³η³»". I think it would be nice to add it to the qieyun autoderiver, if possible.

Copy link
Member

@graphemecluster graphemecluster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking, otherwise LGTM

decorated_kanon.js Outdated Show resolved Hide resolved
Comment on lines +29 to +36
if (is`ε…₯聲 δΈ‰η­‰`) {
if (is`εΉ«η΅„`) return 'Ε«k';
if (is`δ»₯母`) return 'ẁīk';
return is`θŽŠη΅„ ζˆ– η« η΅„` ? 'yΕ«k' : 'wΔ«k';
}
if (is`δΈ‰η­‰`) {
return is`εΉ«η΅„` ? 'Ε«ng' : 'iΕ«ng';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is`ε…₯聲 δΈ‰η­‰`) {
if (is`εΉ«η΅„`) return 'Ε«k';
if (is`δ»₯母`) return 'ẁīk';
return is`θŽŠη΅„ ζˆ– η« η΅„` ? 'yΕ«k' : 'wΔ«k';
}
if (is`δΈ‰η­‰`) {
return is`εΉ«η΅„` ? 'Ε«ng' : 'iΕ«ng';
}
if (is`δΈ‰η­‰`) {
if (is`θˆ’θ²`) return is`εΉ«η΅„` ? 'Ε«ng' : 'iΕ«ng';
if (is`εΉ«η΅„`) return 'Ε«k';
if (is`δ»₯母`) return 'ẁīk';
return is`θŽŠη« η΅„` ? 'yΕ«k' : 'wΔ«k';
}

It seems like this is the only case that there are differences between θˆ’θ² and ε…₯聲 (not including nasal ↔ plosive codas)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's one of a few inconsistencies in attested Kan-on that I've incorporated in here, on a somewhat arbitrary basis. I had to make a judgment call as to which ones were worth keeping. I think the rationale here was, there are a fair amount of common characters with common Kan-on that reflected these differences.

Comment on lines +87 to +89
if (is`合口 非(見硄 ζˆ– ε½±η΅„ ζˆ– δ»₯母)`) return 'uΓ―';
if (is`合口`) return is`δ»₯母 ζˆ– (重紐A鑞 (εΉ«η΅„ ζˆ– 見硄 ζˆ– ε½±η΅„))` ? 'ẁï' : 'wΓ―';
return is`δ»₯母 ζˆ– (重紐A鑞 (εΉ«η΅„ ζˆ– 見硄 ζˆ– ε½±η΅„))` ? 'yΓ―' : 'Γ―';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (is`合口 非(見硄 ζˆ– ε½±η΅„ ζˆ– δ»₯母)`) return 'uΓ―';
if (is`合口`) return is`δ»₯母 ζˆ– (重紐A鑞 (εΉ«η΅„ ζˆ– 見硄 ζˆ– ε½±η΅„))` ? 'ẁï' : 'wΓ―';
return is`δ»₯母 ζˆ– (重紐A鑞 (εΉ«η΅„ ζˆ– 見硄 ζˆ– ε½±η΅„))` ? 'yΓ―' : 'Γ―';
if (is`合口 非(見影硄 ζˆ– δ»₯母)`) return 'uΓ―';
if (is`合口`) return is`δ»₯母 ζˆ– 重紐A鑞 鈍音` ? 'ẁï' : 'wΓ―';
return is`δ»₯母 ζˆ– 重紐A鑞 鈍音` ? 'yΓ―' : 'Γ―';

and so on
鈍音 can actually be omitted, IIRC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decorated_kanon.js Outdated Show resolved Hide resolved
decorated_kanon.js Outdated Show resolved Hide resolved
decorated_kanon.js Outdated Show resolved Hide resolved
justinsilvestre and others added 3 commits February 29, 2024 14:25
Co-authored-by: 归素叒集・ぐらちぃーむ <[email protected]>
decorated_kanon.js Outdated Show resolved Hide resolved
@graphemecluster
Copy link
Member

@syimyuzya @untunt Wanna review before merging?

@ayaka14732 ayaka14732 requested review from syimyuzya and removed request for ayaka14732 March 8, 2024 13:13
Copy link
Member

@syimyuzya syimyuzya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is, why this should be included in qieyun-examples? πŸ€” (It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)

To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon πŸ™ˆ).

@justinsilvestre
Copy link
Contributor Author

justinsilvestre commented Mar 9, 2024

The question is, why this should be included in qieyun-examples?

Not sure who you're asking πŸ˜… but maybe it would be a good idea to formalize some "criteria for inclusion" and document them here in this repo. I just saw there were a few other obscure Middle Chinese notations here, so I figured one more would be welcome.

(It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)

Thanks 😊

To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon πŸ™ˆ).

Fair enough. If it helps, I can make sure to handle any necessary updates to this file in the event or a Qieyun.js update.

@syimyuzya
Copy link
Member

maybe it would be a good idea to formalize some "criteria for inclusion" and document them

If that's gonna be the case, it will probably be "TUPA and reconstructions of MC or Old Mandarin only" (not even Polyhedron's romanization would make it) πŸ˜‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants