-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decorated Kan-on romanization #56
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicking, otherwise LGTM
if (is`ε ₯θ² δΈη`) { | ||
if (is`εΉ«η΅`) return 'Ε«k'; | ||
if (is`δ»₯ζ―`) return 'αΊΔ«k'; | ||
return is`θη΅ ζ η« η΅` ? 'yΕ«k' : 'wΔ«k'; | ||
} | ||
if (is`δΈη`) { | ||
return is`εΉ«η΅` ? 'Ε«ng' : 'iΕ«ng'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (is`ε ₯θ² δΈη`) { | |
if (is`εΉ«η΅`) return 'Ε«k'; | |
if (is`δ»₯ζ―`) return 'αΊΔ«k'; | |
return is`θη΅ ζ η« η΅` ? 'yΕ«k' : 'wΔ«k'; | |
} | |
if (is`δΈη`) { | |
return is`εΉ«η΅` ? 'Ε«ng' : 'iΕ«ng'; | |
} | |
if (is`δΈη`) { | |
if (is`θθ²`) return is`εΉ«η΅` ? 'Ε«ng' : 'iΕ«ng'; | |
if (is`εΉ«η΅`) return 'Ε«k'; | |
if (is`δ»₯ζ―`) return 'αΊΔ«k'; | |
return is`θη« η΅` ? 'yΕ«k' : 'wΔ«k'; | |
} |
It seems like this is the only case that there are differences between θθ² and ε ₯θ² (not including nasal β plosive codas)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's one of a few inconsistencies in attested Kan-on that I've incorporated in here, on a somewhat arbitrary basis. I had to make a judgment call as to which ones were worth keeping. I think the rationale here was, there are a fair amount of common characters with common Kan-on that reflected these differences.
if (is`εε£ ι(θ¦η΅ ζ ε½±η΅ ζ δ»₯ζ―)`) return 'uΓ―'; | ||
if (is`εε£`) return is`δ»₯ζ― ζ (ιη΄Aι‘ (εΉ«η΅ ζ θ¦η΅ ζ ε½±η΅))` ? 'αΊΓ―' : 'wΓ―'; | ||
return is`δ»₯ζ― ζ (ιη΄Aι‘ (εΉ«η΅ ζ θ¦η΅ ζ ε½±η΅))` ? 'yΓ―' : 'Γ―'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (is`εε£ ι(θ¦η΅ ζ ε½±η΅ ζ δ»₯ζ―)`) return 'uΓ―'; | |
if (is`εε£`) return is`δ»₯ζ― ζ (ιη΄Aι‘ (εΉ«η΅ ζ θ¦η΅ ζ ε½±η΅))` ? 'αΊΓ―' : 'wΓ―'; | |
return is`δ»₯ζ― ζ (ιη΄Aι‘ (εΉ«η΅ ζ θ¦η΅ ζ ε½±η΅))` ? 'yΓ―' : 'Γ―'; | |
if (is`εε£ ι(θ¦ε½±η΅ ζ δ»₯ζ―)`) return 'uΓ―'; | |
if (is`εε£`) return is`δ»₯ζ― ζ ιη΄Aι‘ ιι³` ? 'αΊΓ―' : 'wΓ―'; | |
return is`δ»₯ζ― ζ ιη΄Aι‘ ιι³` ? 'yΓ―' : 'Γ―'; |
and so on
ιι³
can actually be omitted, IIRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: ε½’η΄ ε’ιγ»γγγ΅γγΌγ <[email protected]>
@syimyuzya @untunt Wanna review before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is, why this should be included in qieyun-examples? π€ (It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)
To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon π).
Not sure who you're asking π but maybe it would be a good idea to formalize some "criteria for inclusion" and document them here in this repo. I just saw there were a few other obscure Middle Chinese notations here, so I figured one more would be welcome.
Thanks π
Fair enough. If it helps, I can make sure to handle any necessary updates to this file in the event or a Qieyun.js update. |
If that's gonna be the case, it will probably be "TUPA and reconstructions of MC or Old Mandarin only" (not even Polyhedron's romanization would make it) π |
Hi π
I have a Middle Chinese notation system a little like ayaka's "ηΆΎι¦ζθι³η³»". I think it would be nice to add it to the qieyun autoderiver, if possible.