Supporting Node12 and above

[HappyZombies]

Apparently, we (master) support Node 4 and above. We should, however, consider following the Node LTS and basically, support Node 12 and above.

The simplest change would be updating the package.json to update the engines to node >= 12.0.

The question is now What and where else would we need to make changes to show we support only Node12 and above? (obviously CI/CD testing, but that convo is for another issue).

Some things that we are merging to development only support Node 12 and above (example, mocha). So would this change be backwards breaking?

A fun little tidbit is that in the previous repository we forked, the travis.yml file actually was failing on Node 4 - Node 10...so maybe we already support Node 12 but just need to update the docs and package.json? https://travis-ci.org/github/oauthjs/node-oauth2-server

[jankapunkt]

We already support Node 12 in the CI and I am running all tests on Node 14 locally so we are fine here.

Also we can be fine by removing bluebird without any replacement and just use native Promises, which will be already breaking for very old Node versions. Related: #19

Edit: also related: #23 because we would need native ES6 functionality which is not fully supported in Node 4 at least

[HappyZombies]

Understood, I guess this issue was more for dropping support for versions below Node 12 really.

[jwerre]

@jankapunkt I was looking at the workflow you set up and I see that it's only testing on node 12. I wonder if it would be better to test in multiple versions? What do you think? Also, see previous comment.

Originally posted by @jwerre in #5 (comment)

[jwerre]

I think we would be fine supporting Node 10. Is there anything here that you guys feel like we need?

[jankapunkt]

I can update the ci to support 10,12,14 and 16

[jwerre]

@jankapunkt... Also, we should be good to remove the travis.yaml correct?

[HappyZombies]

I think removing the Travis file is fine. We are using GitHub CI now.

[jankapunkt]

PR is open :-) #35

[jwerre]

We should change this to Node 12:

[jankapunkt]

The travis.yml is removed. Should I set the node version up to >=12 @jwerre ?

[HappyZombies]

@jankapunkt I totally overlooked this, we can make another PR