Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display og images in social media #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

With this, the images will be displayed on social media. It's not very important, but it's a small detail

https://nodejs.org/en/next-data/og/announcement/All%20%7C%20Node.js%20v22.14.0%20Documentation

output:
image

@bjohansebas bjohansebas requested a review from a team as a code owner March 24, 2025 02:57
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! But we should have ability to op-out OG image. Because nodejs/nodejs.org can be output as static so OG will be 404

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjohansebas
Copy link
Member Author

But we should have ability to op-out OG image. Because nodejs/nodejs.org can be output as static so OG will be 404

Any idea how to solve that? Also, if that starts returning 404, then the OG image wouldn't work on nodejs/nodejs.org either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants