Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add Windows ARM64 to flaky-tests list #54693

Merged
merged 3 commits into from
Sep 6, 2024
Merged

meta: add Windows ARM64 to flaky-tests list #54693

merged 3 commits into from
Sep 6, 2024

Conversation

RedYetiDev
Copy link
Member

As seen in #54645, it is possible for issues to only affect this specific platform, so this PR adds it to selection menu when reporting a flaky test.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 1, 2024
targos
targos reviewed Sep 1, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm but I think the other entry should specify x64, like for macOS

@RedYetiDev RedYetiDev added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. windows Issues and PRs related to the Windows platform. arm Issues and PRs related to the ARM platform. labels Sep 1, 2024
mcollina
mcollina approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit c046c9b into nodejs:main Sep 6, 2024
15 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c046c9b

anonrig pushed a commit to anonrig/node that referenced this pull request Sep 10, 2024
@RedYetiDev @anonrig
meta: add Windows ARM64 to flaky-tests list
0945140 
PR-URL: nodejs#54693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RedYetiDev @aduh95
meta: add Windows ARM64 to flaky-tests list
82c08ef 
PR-URL: #54693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj left review comments

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RedYetiDev @nodejs-github-bot @mcollina @lpinca @targos @wojtekmaj