Backports to v18.x #246
Closed
Backports to v18.x #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, a couple of fixes in the updater: - Fix OPENTELEMETRY_VERSION extraction. - Use `third_party_release` file to get the `opentelemetry-proto`. PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]> PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]>
`lineNumber`, `columnNumber` and `url` node fields can be actually undefined. Make sure we avoid integer overflows and potential crashes. As an example, if `lineNumber` or `columnNumber` are undefined, they were taking the `4294967295` which obviously doesn't make any sense. PR-URL: #233 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #238 Reviewed-By: Juan José Arboleda <[email protected]>
The runtime now stores the `scriptId` and `url` or `path` of all the loaded cjs and esm modules. A new grpc command has been added to retrieve the source code for any `scriptId`-`url|path` pair by reading the source code from file. In case the specific `scriptId`-`url|path` pair wasn't stored, it returns an error. In the rare case where a ESM is not loaded from a file URL, the code would be stored on loading time. PR-URL: #240 Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #239 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #241 Reviewed-By: Juan José Arboleda <[email protected]>
This will allow less grpc threads/resources to be used. PR-URL: #242 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #236 Reviewed-By: Juan José Arboleda <[email protected]>
While also making sure we're able to connect correctly to both production and staging hosts. PR-URL: #237 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #243 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #248 Reviewed-By: Rafael Gonzaga <[email protected]>
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <[email protected]>
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
Also, a couple of fixes in the updater: - Fix OPENTELEMETRY_VERSION extraction. - Use `third_party_release` file to get the `opentelemetry-proto`. PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]> PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #221 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
`lineNumber`, `columnNumber` and `url` node fields can be actually undefined. Make sure we avoid integer overflows and potential crashes. As an example, if `lineNumber` or `columnNumber` are undefined, they were taking the `4294967295` which obviously doesn't make any sense. PR-URL: #233 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #238 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
The runtime now stores the `scriptId` and `url` or `path` of all the loaded cjs and esm modules. A new grpc command has been added to retrieve the source code for any `scriptId`-`url|path` pair by reading the source code from file. In case the specific `scriptId`-`url|path` pair wasn't stored, it returns an error. In the rare case where a ESM is not loaded from a file URL, the code would be stored on loading time. PR-URL: #240 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #246
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #239 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #241 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
This will allow less grpc threads/resources to be used. PR-URL: #242 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #236 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
While also making sure we're able to connect correctly to both production and staging hosts. PR-URL: #237 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #243 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
PR-URL: #248 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #246
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
`OtlpGrpcClientOptions.use_ssl_credentials` is not initialized by default to `false` as it happens with all their children. Make sure it is otherwise it can produce undesired behaviour. PR-URL: #247 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #246
santigimeno
added a commit
that referenced
this pull request
Jan 13, 2025
And in general, make the `saas` config option handling more robust and consistent. PR-URL: #235 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #246 Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It backports everything from the v22.x branch but the undici patch. This means no tracing support for fectch in v18.x, but v18.x EOL is close.