Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: getting rid of BigNum struct (WIP) #151

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat!: getting rid of BigNum struct (WIP) #151

wants to merge 10 commits into from
+790 −667

Conversation

kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Mar 20, 2025 •
edited
Loading

Description

We move the BigNumTrait impls into a compttime macro.
For each BigNum type that we construct, we call this macro to implement all the functions in the trait
with the correct generics.

Problem*

Resolves
#142

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Sorry, something went wrong.

TomAFrench
TomAFrench reviewed Mar 25, 2025
View reviewed changes
kashbrti
kashbrti commented Mar 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Noir Libraries
Status: 👀 To Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kashbrti @TomAFrench