Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7515 allowing search feature by 'Name' on the product attribute page… #7524

Closed

Conversation

qasas145
Copy link

@qasas145 qasas145 commented Jan 28, 2025

… (admin area)
#7515 allowing search feature by 'Name' on the product attribute page

  • I have updated the List.cshtml to add a search box so that we can filter product attributes by name
  • and also updated IProductAttributeService.cs to include a searchModelName as an optional parameter in the method GetAllProductAttributesAsync
  • also updated ProductAttributeService.cs to use this searchModelName in the GetAllProductAttributesAsync method
  • and also a added SearchModelName property to ProductAttributeSearchMode.csl so that we can filter product attribute by it

@sateeshmunagala
Copy link

It would be good If the search feature is available for Specification attribute options as well.
We have 3000 specification attribute options . So search feature is very helpful.
Request you consider creating a PR for the same

@qasas145
Copy link
Author

It would be good If the search feature is available for Specification attribute options as well. We have 3000 specification attribute options . So search feature is very helpful. Request you consider creating a PR for the same

Ok thank you

@qasas145
Copy link
Author

qasas145 commented Feb 2, 2025

So search feature is very helpful
@sateeshmunagala see this :
#7546
this a PR in which i added searching by specification attribute name in the specification attributes page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants