Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing Core tech stack #1394

Open
wants to merge 4 commits into
base: release53
Choose a base branch
from
Open

Modernizing Core tech stack #1394

wants to merge 4 commits into from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Mar 5, 2025

About the Contributor

This is a pull request that consists of changes from BBC (@Julusian ), modified and refactored by NRK.

Type of Contribution

This is a: Code improvement

New Behavior

This PR updates dependencies to the code-standard-preset library, updating the eslint and prettier to more modern versions.

As a consequence, this also affects a large part of the code base (with reformattings and other minor changes).

FOR CONTRIBUTORS

Here are instructions for how to apply this PR without getting thousands of merge conflicts:

  1. Cherry-pick the commit chore: update code-preset and configs onto your branch.
  2. Cherry-pick the commit chore: add reformatting script onto your branch.
  3. Run node scripts/reformat.mjs
    This will apply the new format rules on your code base and fix various common issues.
    Commit this as chore: apply reformatting
  4. Cherry-pick the commit chore: apply various minor fixes after reformatting onto your branch, and solve any merge conflicts.
  5. Fix any lingering issues in your code base, check with
    a. yarn
    b. 'yarn install-and-build'
    c. yarn lint
    d. yarn unit
    e. yarn start
    f. (or run yarn test-all)

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner March 5, 2025 09:36
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 50.77519% with 127 lines in your changes missing coverage. Please review.

Please upload report for BASE (release53@f3d84af). Learn more about missing BASE report.

Files with missing lines Patch % Lines
meteor/server/api/rest/v1/typeConversion.ts 0.00% 17 Missing ⚠️
meteor/server/publications/lib/quickLoop.ts 0.00% 14 Missing ⚠️
meteor/server/migration/1_50_0.ts 46.66% 8 Missing ⚠️
meteor/server/api/snapshot.ts 12.50% 7 Missing ⚠️
meteor/server/cronjobs.ts 0.00% 6 Missing ⚠️
meteor/server/api/blueprints/api.ts 37.50% 5 Missing ⚠️
meteor/server/worker/worker.ts 0.00% 5 Missing ⚠️
packages/corelib/src/error.ts 54.54% 5 Missing ⚠️
packages/corelib/src/playout/infinites.ts 68.75% 5 Missing ⚠️
meteor/server/api/organizations.ts 0.00% 4 Missing ⚠️
... and 23 more
Additional details and impacted files
@@             Coverage Diff              @@
##             release53    #1394   +/-   ##
============================================
  Coverage             ?   54.28%           
============================================
  Files                ?      406           
  Lines                ?    72736           
  Branches             ?     5471           
============================================
  Hits                 ?    39485           
  Misses               ?    32994           
  Partials             ?      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants