fix typescript config

nrwl · Jan 24, 2025 · d2684ef · d2684ef
1 parent c9b919e
commit d2684ef
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/libs/vscode/nx-cloud-view/src/cloud-view-state-machine.ts b/libs/vscode/nx-cloud-view/src/cloud-view-state-machine.ts
@@ -17,7 +17,7 @@ import {
   setup,
   spawnChild,
 } from 'xstate';
-// @ts-expect-error -- need this import for type inference
+// need this import for type inference
 import type { Guard } from 'xstate/guards';
 
 const SLEEP_POLLING_TIME = 3_600_000;

diff --git a/libs/vscode/telemetry/src/lib/google-analytics-sender.ts b/libs/vscode/telemetry/src/lib/google-analytics-sender.ts
@@ -4,7 +4,6 @@ import { env, ExtensionContext, extensions, TelemetrySender } from 'vscode';
 
 import { getOutputChannel } from '@nx-console/vscode-output-channels';
 
-// @ts-expect-error -- Browser Rollbar is not typed
 import Rollbar = require('rollbar/src/browser/rollbar');
 import { getNxVersion } from '@nx-console/vscode-nx-workspace';
 import { onWorkspaceRefreshed } from '@nx-console/vscode-lsp-client';

diff --git a/libs/vscode/verify/src/lib/verify-builder-definition.ts b/libs/vscode/verify/src/lib/verify-builder-definition.ts
@@ -63,7 +63,11 @@ export async function verifyBuilderDefinition(
   options: Array<Option>;
 }> {
   const projects = projectGraph.nodes || {};
-  const projectDef = projects[project] || {};
+  const projectDef = projects[project] || {
+    data: {
+      targets: {},
+    },
+  };
   const targetDef = projectDef.data.targets || {};
   const commandDef = targetDef[command] || {};
   const configurations = Object.keys(commandDef.configurations || {});

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -19,15 +19,15 @@
     "noEmitOnError": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
-    "noImplicitReturns": true,
-    "noUnusedLocals": true,
+    "noImplicitReturns": false,
+    "noUnusedLocals": false,
     "pretty": true,
     "removeComments": false,
     "resolveJsonModule": false,
     "skipDefaultLibCheck": false,
     "skipLibCheck": true,
     "sourceMap": false,
-    "strict": true,
+    "strict": false,
     "target": "es2022",
     "verbatimModuleSyntax": false
     // "sourceMap": true,