Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nxls): provide autocomplete only for plugins that contain nx #2365

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Dec 16, 2024

Before, we would sometimes show unrelated plugins in our autocomplete.
image

Once we have a better way of detecting whether a plugin provides an inference plugin, we can update this. But for now let's err on the side of caution - I'd rather miss certain third-party plugins than regularly show flat-out wrong things.

Copy link

nx-cloud bot commented Dec 16, 2024

Your CI Pipeline Execution ↗ for commit d2fafc6 ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e-ci --... ✅ Succeeded 8m, 53s View ↗
nx-cloud record -- yarn nx-cloud conformance:check ✅ Succeeded 10s View ↗
nx-cloud record -- yarn nx sync:check ✅ Succeeded 9s View ↗
nx-cloud record -- ./gradlew ktfmtCheck ✅ Succeeded 4s View ↗
nx-cloud record -- ./gradlew projectReportAll ✅ Succeeded 20s View ↗
nx affected --targets=build,test,e2e-ci --confi... ✅ Succeeded 25m, 31s View ↗

Last updated at 2024-12-16 11:04:19UTC

Sent with 💌 from NxCloud.

@MaxKless MaxKless merged commit d94aa70 into master Dec 16, 2024
5 checks passed
@MaxKless MaxKless deleted the show-nx-plugins-only branch December 16, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants