Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide extract tags tab for Reach+. Show FMOD Repair tab for Reach #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pepper-Man
Copy link
Contributor

Simple changes to help avoid user confusion:

  • Only show "Extract Tags" tab when profile is H2/H3/ODST. Previously was shown for Reach and H4/2AMP as well - incorrectly reporting success despite those tags not having source info
  • Allow "FMOD Repair" tab to show when selected profile is Reach, in addition to H3/ODST. Have tested with Reach and the fix process is identical so no code change is required

@Pepper-Man
Copy link
Contributor Author

I also think that whether we actually hide or just "disable" a given tab when it is not used by a profile should be made more consistent. For example "Import Model" and "Import Sound" tabs are just greyed out for H4/2AMP as they can't be used, but the "Extract Tags" tab isn't just disabled for CE, but hidden entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant