Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container-level version compatibility check for monovertex #2108

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Oct 1, 2024

Transformer e2es are failing but not introduced by this PR.

rust-lang-nursery/lazy-static.rs#214

.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 91.59664% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (e69551b) to head (24519ef).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/shared/server_info.rs 91.15% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
- Coverage   64.49%   64.23%   -0.27%     
==========================================
  Files         324      324              
  Lines       30579    30647      +68     
==========================================
- Hits        19723    19687      -36     
- Misses       9818     9920     +102     
- Partials     1038     1040       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang marked this pull request as ready for review October 1, 2024 16:11
@vigith vigith requested review from yhl25 and kohlisid October 1, 2024 21:50
@KeranYang KeranYang enabled auto-merge (squash) October 1, 2024 22:38
@whynowy whynowy merged commit 3dbed43 into numaproj:main Oct 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants