Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hidden-curriculum.po to Spanish #38

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

AnushkaChauhan111
Copy link

This pull request translates the hidden-curriculum.po file into Spanish.

File Translated: locales/es/LC_MESSAGES/hidden-curriculum.po
Total Strings Translated: 141
Please review the changes and let me know if there are any further adjustments needed.

@melissawm
Copy link
Collaborator

Hi @AnushkaChauhan111 - this looks mixed up with some German translations. Perhaps it is part of an automated process of some kind?

@AnushkaChauhan111
Copy link
Author

Hi @melissawm,
Thanks for pointing that out. I've changed the German translations to Spanish in the hidden-curriculum.po. Please take a look at the latest commit in the pull request and let me know if there are any further changes needed!

@AnushkaChauhan111
Copy link
Author

I've translated the content and made corrections to formatting and spacing for better clarity. As I'm still a beginner, I'm open to any suggestions for improvements. Your feedback would be greatly appreciated!

@melissawm
Copy link
Collaborator

Hi @AnushkaChauhan111 - this repository is the result of an event that happened in 2023, and each group is responsible for the document they helped write. I was not in this group so will leave the review to one of the participants.

@AnushkaChauhan111
Copy link
Author

Sure, thank you.

Copy link
Collaborator

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not my project but as it is a translation I figured I could help review. First of all, thanks for the work in translating, it took me quite a while to review so it probably took a significant amount of time to translate too.

I have added many comments, but a large portion of these are related to the translation format and syntax. I am not sure if I caught anything but only the text in msgstr and inside " is taken into account, nothing less and nothing more. This means that:

"Start of a sentence"
"that continues below"

will end up like: start of a sentencethat continues below as there is no space after sentence nor before that.

"First sentence that ends in punctuation mark".
" Second sentence."

would be: First sentence that ends in punctuation mark Second sentence. (or maybe even break the renderer due to the dot outside the ")

Also, changes in the msgid are at best ignored and at worse break the linking of a translated string with the source so the translation is not properly caught and ends up unused, fixes and improvements to the English content should happen directly to https://github.com/numfocus/disc-unconference-2023-projects/blob/main/unconference/hidden-curriculum.md

locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/hidden-curriculum.po Outdated Show resolved Hide resolved
AnushkaChauhan111 and others added 19 commits October 18, 2024 18:12
… to "querrías" and "pregunté" to "preguntaste" for consistency in second-person singular.

Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
AnushkaChauhan111 and others added 15 commits October 18, 2024 19:06
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
Co-authored-by: Oriol Abril-Pla <[email protected]>
@AnushkaChauhan111
Copy link
Author

Thanks again for your input! I've committed most of your suggested changes, except the two you mentioned uncertainty about (the gender-neutral terms and the engineering background part). I didn’t want to adjust those without clarity. Let me know if anything else comes to mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants