filter packages by platform #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you don't add the packages as checks explicitly, aren't they only evaluated? Or are they also built? |
|
Quick check here seems to suggest they are only evaled, as you say. So i dropped the second commit So it does make sense to have both. And at least in theory the eval cache should probably kick in here and save us from evaluating each package twice? |
phaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit ensures that we only get an output per package on platforms that package supports.
nix flake check does check all packages by default, so thepkg-*might be regarded as duplicates. On the other hand, they don't show up in the checks output, which probably means CI would skip them with buildbot-nix et al. :/Shall we just drop the second commit and evaluate them twice?