[python/matplotlib/pyplot] Add suport for ec and fc in arrow #1648
+560,602
−27,093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not necessary when it was only used for the expressions variable box, because the background was already of the right color thanks to the previous displayed menu. We need to draw it for the python variable box.
- It sould be nameOfScript.py, not just nameOfScript, when the source is a script - Fix the source for script name variables. For instance, "from script1 import *" should display the node "script1" with the source "script1.py" - If a script has the same name as a module, the module will be imported and not the script, so do not load its variables (even if the module is not in the toolbox).
After lauching the console, if we fetch a script we mark it as fetched. When the variable box displays variables from imported scripts, it scans all the variables from the scripts marked as fetched.
In the variable box
After scrolling down
Because we can now, it might need to be de-factorized later, if more classes inherit from alternate_empty_nested_menu_controller
And assert_expression_simplify -> assert_expression_reduce
Take care of an undefined index that arrived during the remove unit
Scenario: f(x) = 0->_A evaluate 0f(0)
UnitConvert::removeUnit replaces the unit ocnvert with an undefined.
calculation height memoization. They're computed from the layouts which don't depend on the complex format (or any other settings parameters which could have changed).
…ells are computed when the calculation is added to the store and don't change afterwards. Otherwise, if their heights change when scrolling (due to a modification of the display output type - ExactOnly, ApproximateOnly...), it generates crashes.
If the commandLength is > than the buffer size, we have to escape at some point to avoid overflowing the buffer.
Change-Id: I610726ed5966d353397be923b76dd003297940a7
Change-Id: I6ebec412b4b6612710476274a8665375d21f9ef8
Without this change, we would get weird "reduced" expression, such as multiplication(undef, _s), but we do not always check sSimplificationHasBeenInterrupted afterwards.
If an expression hasUnits and is then reduced, it might not have units anymore for instance if it was replaced with undefined). Scenario: Enter "[5000000000000000]^20 _s" in the calculation app
Change-Id: I99a523e9e88ea9c3064e4367d96b01edb0020df9
Change-Id: I7a5e12f6f3d79da802149a6aeef88387941ccdd8
|
EmilieNumworks
force-pushed
the
master
branch
2 times, most recently
from
e385767 to
974bf08
Compare
EmilieNumworks
force-pushed
the
master
branch
from
bb3baa7 to
e4c3a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1647, like the behaviour of graph 90+E (this doesn't reproduce the behaviour of real pyplot).