Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MTP wording from Microsoft Test Platform to Microsoft.Testing.Platform #1018

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Update MTP wording from Microsoft Test Platform to Microsoft.Testing.Platform #1018

merged 2 commits into from
Feb 10, 2025

Conversation

Youssef1313
Copy link
Contributor

No description provided.

@SeanKilleen
Copy link
Member

Seems silly to have Microsoft.Test.Platform be the human-readable name, but this does appear to be the official name, so I'll accept it.

SeanKilleen
SeanKilleen reviewed Feb 10, 2025
View reviewed changes
docs/articles/vs-test-adapter/NUnit-And-Microsoft-Test-Platform.md
* [Use Microsoft.Testing.Platform with dotnet test](https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-integration-dotnet-test)
* [Microsoft Test Platform Architecture](https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-architecture)
* [Microsoft.Testing.Platform](https://learn.microsoft.com/dotnet/core/testing/unit-testing-platform-intro)
* [Use Microsoft.Testing.Platform with dotnet test](https://learn.microsoft.com/dotnet/core/testing/unit-testing-platform-integration-dotnet-test)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 Nice catch on removing the default en-us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit to @Evangelink :)

@SeanKilleen
Copy link
Member

The build only fails here due to a known issue, #983. So, going to merge this. Thank you for the contribution! 🎉

@SeanKilleen SeanKilleen merged commit 7ef9d26 into nunit:master Feb 10, 2025
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
@SeanKilleen
Update MTP wording from Microsoft Test Platform to Microsoft.Testing.…
9bdea37 
…Platform (#1018)

* Update MTP wording from Microsoft Test Platform to Microsoft.Testing.Platform

* Remove 'en-us' from Microsoft links 7ef9d26
@Youssef1313 Youssef1313 deleted the patch-1 branch February 10, 2025 13:32
@Evangelink
Copy link

Seems silly to have Microsoft.Test.Platform be the human-readable name

I agree :) Sadly codenames are not allowed and I really didn't wanted us to be called VSTest. Given anything library is not allowed to have identity on its own we went with the common pattern of Microsoft.Area.SubArea.

@SeanKilleen
Copy link
Member

@Evangelink I just meant that it might make sense to call it "Microsoft Test Platform" instead of "Microsoft.Test.Platform".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanKilleen SeanKilleen SeanKilleen approved these changes

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @SeanKilleen @Evangelink