-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new regex routing #2937
base: main
Are you sure you want to change the base?
Conversation
I've caught a memory leak when using routeToObject instead of:
In this case, all tests start to lag. It seems like this issue might be relevant to any code where routeToObject is used |
Revised Routing Description:1. Primary Route:
2. Localized Route:
3. Custom Routes:
Additional Enhancements:
Code Explanation:
Route Search Process:
|
I've fixed all the tests, but there are still some warnings left that I couldn't catch locally; my tests don't show them. Maybe you'll be able to catch them. The resolve function sometimes passes the locale parameter where it's not needed (to routes without a locale), but it's already possible to start reviewing and testing. I also had to adjust two tests. One issue was related to i18n, and for the second one, I'm out of energy to fix it. |
I was wondering if there might be an update on the timeline for merging this? Thank you for your time and consideration. |
I was a bit busy the last few months but I'm still considering this feature as we're working v9, no timeline though. |
β Type of change
π Description
The new version of this commit #2927 includes a new routing system. However, I was unable to complete the last two tests:
specs/routing/prefix-and-default.spec.ts > localePath > route strategy: prefix_and_default > should be worked.
These are related to link generation. Unfortunately, I still can't figure out how it works or how to fix it.
Everything is functioning now, please take a look when you have time.
The description was in the previous pull request.
π Checklist