Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-utils): define $attrs in component render context #1108

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

romhml
Copy link
Contributor

@romhml romhml commented Feb 1, 2025

πŸ”— Linked issue

Resolves #1092

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixes an issue where $attrs are undefined when mounting a component using mountSuspended .

@romhml romhml requested a review from danielroe as a code owner February 1, 2025 10:40
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also apply the same fix to renderSuspended?

@romhml romhml force-pushed the fix/missing-attrs branch from a8efd33 to 2f76aba Compare February 1, 2025 11:49
@romhml romhml force-pushed the fix/missing-attrs branch from 2f76aba to cc5bd48 Compare February 1, 2025 11:50
@romhml
Copy link
Contributor Author

romhml commented Feb 1, 2025

Done @danielroe! I tweaked the wrapper component a bit because it was inheriting attributes too.

@romhml romhml changed the title fix(mountSuspended): define $attrs in component render context fix(mountSuspended,renderSuspended): define $attrs in component render context Feb 1, 2025
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@danielroe danielroe changed the title fix(mountSuspended,renderSuspended): define $attrs in component render context fix(runtime-utils): define $attrs in component render context Feb 1, 2025
@danielroe danielroe merged commit 5fe65ec into nuxt:main Feb 1, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mountSuspended fails to pass attributes when inheritAttrs is false
2 participants