feat(Table): emit expand event
#2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (openedRows.value.includes(index)) { | ||
| openedRows.value = openedRows.value.filter((i) => i !== index) | ||
| } else { | ||
| openedRows.value.push(index) | ||
| emit('update:expand', { expandedRows: openedRows.value, row }) |
There was a problem hiding this comment.
Shouldn't this be emitted in both case?
There was a problem hiding this comment.
Should it? I think it could be either emitted in both cases and the information whether it was an "expand" or "collapse" could be added as a function parameter to the user or there could be another emit like update:collapse. What do you think?
There was a problem hiding this comment.
Since you send the openedRows in the event, we should emit each time the openedRows.value changes I guess.
benjamincanac
changed the title
expand eventexpand event
Comment on lines
357
to
362
| if (openedRows.value.includes(index)) { | ||
| openedRows.value = openedRows.value.filter((i) => i !== index) | ||
| } else { | ||
| openedRows.value.push(index) | ||
| emit('update:expand', { expandedRows: openedRows.value, row }) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (openedRows.value.includes(index)) { | |
| openedRows.value = openedRows.value.filter((i) => i !== index) | |
| } else { | |
| openedRows.value.push(index) | |
| emit('update:expand', { expandedRows: openedRows.value, row }) | |
| } | |
| if (openedRows.value.includes(index)) { | |
| openedRows.value = openedRows.value.filter((i) => i !== index) | |
| } else { | |
| openedRows.value.push(index) | |
| } | |
| emit('update:expand', { expandedRows: openedRows.value, row }) |
|
Would you mind fix the conflicts? |
8 tasks
|
Closing in favor of #2485. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #2062
❓ Type of change
📚 Description
Emitting an event when a row is expanded. Useful for e.g. fetching data before the row is expanded.
📝 Checklist