Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved DFP documentation, logging and fix MonitorStage #2106

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 14, 2025

Description

Monitor Stage Changes

  • Only build a C++ node for MonitorStage if the message type is supported on the C++ side.
  • Ensure the MonitorStage is omitted from the pipeline if silenced by the configured log level (this optimization existed for the Python node, this change just applies it to the C++ node).

DFP Changes

  • Update the version of Morpheus used by the DFP Docker containers, and add it to the ci/release/update-version.sh script.
  • Set the default log level for DFP pipelines to INFO
  • Document fetching the DFP datasets from within the docker container. This allows for an all-docker workflow, and avoids the need for users to create a Conda environment on their host system just to download the example data.
  • Document that the DFP pipelines can be run from either the CLI or from a Jupyter Notebook.
  • Update fetch_example_data.py to print output if the dataset has already been fetched.

Closes #2105
Closes #2100
Closes #2101

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 14, 2025
@dagardner-nv dagardner-nv self-assigned this Jan 14, 2025
@dagardner-nv dagardner-nv requested review from a team as code owners January 14, 2025 17:27
@dagardner-nv dagardner-nv changed the title DFP Fixes Improved DFP documentation, logging and fix MonitorStage Jan 14, 2025
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c5c8789 into nv-morpheus:branch-25.02 Jan 14, 2025
11 checks passed
@dagardner-nv dagardner-nv deleted the david-dfp-docs-2100-2101 branch January 14, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
2 participants