Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tutorial 02 to CI #566

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add tutorial 02 to CI #566

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85533b5
run tutorial 02 in CI
Trivo25 Aug 17, 2023
00abd02
add comments
Trivo25 Aug 17, 2023
db20ab3
node version
Trivo25 Aug 28, 2023
9a66192
Merge branch 'main' into tutorial-runner-tutorial-2
Trivo25 Aug 28, 2023
fe89c95
Merge branch 'main' into tutorial-runner-tutorial-2
barriebyron Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/test-tutorials.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,17 @@ jobs:
git config --global user.email "[email protected]"
git config --global user.name "Test"
npx ts-node scripts/tutorial-runner.ts docs/zkapps/tutorials/01-hello-world.mdx

private-inputs-and-hash-functions:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
# In case of version change, update README.md accordingly
node-version: 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should update the node version here and with the other tutorials in CI because node 16 has reached end of life.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, @shimkiv has landed o1-labs/zkapp-cli#479

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the right update here?

- run: |
npm ci
git config --global user.email "[email protected]"
git config --global user.name "Test"
npx ts-node scripts/tutorial-runner.ts docs/zkapps/tutorials/02-private-inputs-hash-functions.mdx
Loading
Loading