-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial 3 to CI #567
Open
Trivo25
wants to merge
18
commits into
main
Choose a base branch
from
tutorial-runner-tutorial-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add tutorial 3 to CI #567
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
38d75ad
test network runner
Trivo25 19a000a
try fixing tutorial runner
Trivo25 9752d71
try fixing tutorial runner
Trivo25 0e92653
try fixing tutorial runner
Trivo25 f6de3b7
try fixing tutorial runner
Trivo25 968d26f
try fixing tutorial runner
Trivo25 3ccbbc3
formatting
Trivo25 aec35bd
cd into working dir
Trivo25 3e431a2
change checkout package version
Trivo25 e4ce0a3
change tutorial path
Trivo25 80a5dc7
e2e test script, wip
Trivo25 4fcfafb
fix deploy script
Trivo25 a193633
add local network container
Trivo25 d4fcb7e
hide auxiliary scripts
Trivo25 ae4fb83
fix grapqhl link
Trivo25 144f6d1
Merge branch 'main' into tutorial-runner-tutorial-3
Trivo25 e78945b
update o1js reference
Trivo25 226be8e
update graphql link
Trivo25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,42 @@ jobs: | |
git config --global user.email "[email protected]" | ||
git config --global user.name "Test" | ||
npx ts-node scripts/tutorial-runner.ts docs/zkapps/tutorials/01-hello-world.mdx | ||
|
||
deploying-network: | ||
timeout-minutes: 25 | ||
runs-on: ubuntu-latest | ||
services: | ||
mina-local-network: | ||
image: o1labs/mina-local-network:rampup-latest-lightnet | ||
env: | ||
NETWORK_TYPE: 'single-node' | ||
PROOF_LEVEL: 'none' | ||
ports: | ||
- 3085:3085 | ||
- 5432:5432 | ||
- 8080:8080 | ||
- 8181:8181 | ||
# TODO: Disable logging for container as the workaround of long post-job-cleanup phase | ||
# - Will be fixed by improving logging as part of the work on: | ||
# - https://hub.docker.com/r/o1labs/mina-local-network | ||
options: --log-driver=none | ||
steps: | ||
- name: Wait for Mina Network readiness | ||
uses: o1-labs/wait-for-mina-network-action@v1 | ||
with: | ||
mina-graphql-port: 8080 | ||
max-attempts: 60 | ||
polling-interval-ms: 10000 | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v3 | ||
with: | ||
node-version: 20 | ||
- name: Run tutorial | ||
env: | ||
USE_LOCAL_NETWORK: 'true' | ||
continue-on-error: false | ||
run: | | ||
npm ci | ||
git config --global user.email "[email protected]" | ||
git config --global user.name "Test" | ||
npx ts-node scripts/tutorial-runner.ts docs/zkapps/tutorials/03-deploying-to-a-network.mdx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity - does the tutorial runner parse this to figure out what option to select? or how does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it only parses shell commands if they begin with
$
, rest is ignoredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how does it select the
none
option then? there's a second snippet which shows the choice but it also doesn't have a leading$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this particular snippet doesn't execute or do anything, it's just rendered to indicate to the reader what to choose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't get how the tutorial runner ends up making a choice for the UI project option 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh!! We have a flag
--ui none
that the runner is using :DThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitschabaude and @Trivo25
The docs style guide describes the tutorial runner, can we verify the technical accuracy, please?
https://github.com/o1-labs/docs2/wiki/Tutorial-Runner