Add tutorial 5 to tutorial runner #577
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| ```ts src/run.ts | ||
| 3 const num1 = UInt32.from(40); | ||
| 4 const num2 = UInt64.from(40); |
There was a problem hiding this comment.
maintaining these line numbers going forward seems tedious to me :/
maybe there could be a default where it just appends to the file when there are no line numbers? (it'll still be tedious but at least only when the line numbers are needed)
There was a problem hiding this comment.
Yes, it is very tedious :( We would have to make some adjustments to the tutorial runner but possible (and probably worth it)
There was a problem hiding this comment.
YAY no more line number requirement! Let's omit the tedious line numbers per convo at offsite
| @@ -294,123 +337,126 @@ If a program is too large to fit into these constraints, it can be broken up int | |||
|
|
|||
| You can use [Merkle trees](../snarkyjs-reference/classes/MerkleTree) to manage large amounts of data within a circuit. The power of Merkle trees is demonstrated in the [05-common-types-and-functions/src](https://github.com/o1-labs/docs2/tree/main/examples/zkapps/05-common-types-and-functions/src) reference project for this tutorial. See the [BasicMerkleTreeContract.ts](https://github.com/o1-labs/docs2/blob/main/examples/zkapps/05-common-types-and-functions/src/BasicMerkleTreeContract.ts) contract and [main.ts](https://github.com/o1-labs/docs2/blob/main/examples/zkapps/05-common-types-and-functions/src/main.ts) that demonstrates how contracts interact with Merkle trees and how to construct them. | |||
|
|
|||
There was a problem hiding this comment.
well.. no big deal to delete, but you could leave it in there if you used an ignore directive like for skipped commands. Do we have that?
EDIT: nvm I saw that you used it elsewhere
There was a problem hiding this comment.
Yes we do have ignore. I can also add it back, I don't mind. I just felt like it was odd that we only mentioned the import for MerkleTree, but didn't talk about importing all the other previous primitives. So rather than adding an import to all the previous sections I removed this one 😅
| this.treeRoot.set(rootAfter); | ||
| } | ||
| ```ts src/run.ts | ||
| 117 class BasicMerkleTreeContract extends SmartContract { |
There was a problem hiding this comment.
hmm, so having the dots ... as a way to tell the tutorial runner "skip any number of lines" would actually be useful. doesn't have to be in this PR but the sooner the better before we have to change all tutorials just because we don't have this feature
| const value = Field(50); | ||
|
|
||
| map.set(key, value); | ||
| ```ts ignore |
There was a problem hiding this comment.
is ignoring all the MerkleMap code intended? ideally we also test that part
|
@Trivo25 I lost track of the status of this PR... were we waiting to merge it until the dependency on line numbers in the tutorial runner is removed? If we are waiting, wdyt we can move the PR to draft? |
closes #514