Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): sapphire: reduce docker layers + 0.6.4 mainnet #463

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Oct 17, 2023

Upgrades the sapphire-dev container to 0.6.4 versus 0.6.4-testnet

The Dockerfile has been reorganized:

  • Reduce the number of layers by combining commands
  • Remove downloaded tar files and unused extracted files

Additionally start.sh, when used with the mock backend, will increment the epoch every 10 minutes - now queries current epoch before advancing, instead of fetching once and incrementing regardless of other things advancing the epoch.

This reduces the docker image size by approx 125mb

@CedarMist CedarMist changed the title feat(docker): reduce docker layers + 0.6.4 mainnet feat(docker): sapphire: reduce docker layers + 0.6.4 mainnet Oct 17, 2023
@CedarMist CedarMist self-assigned this Oct 17, 2023
@CedarMist CedarMist added p:2 Priority: desired feature docker Docker related issues labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #463 (2a410d6) into main (e7c5045) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   62.03%   62.03%           
=======================================
  Files          37       37           
  Lines        3909     3909           
=======================================
  Hits         2425     2425           
  Misses       1276     1276           
  Partials      208      208           

@CedarMist CedarMist marked this pull request as ready for review October 17, 2023 21:57
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Too bad there's still no CI that would test the image

@CedarMist CedarMist merged commit daa18e5 into main Oct 19, 2023
6 checks passed
@CedarMist CedarMist deleted the CedarMist/fewer-docker-layers branch October 19, 2023 13:09
@CedarMist
Copy link
Member Author

@ptrus We can talk next week about the bigger picture of testing & circular dependencies etc. and how to untangle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related issues p:2 Priority: desired feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants