-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sapphire-localnet: Add support for running ROFLs #614
Conversation
092a726
to
8a1b250
Compare
8a1b250
to
9641355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests in sapphire-paratime are failing with this, namely the hardhat-ignition (Ethers) tests. Investigating.
They also seem to be failing with existing sapphire-localnet image, so it's not your problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation (originally the file used tabs, but some joker changed it to spaces and now it's chaos -- some parts use 4 spaces, some 2... 😞).
docker/common/start.sh
Outdated
|
||
echo | ||
notice "Configuring ROFL ${ROFLS[0]}:\n" | ||
printf " Enclave ID ${CYAN}${ROFL_ENCLAVE_ID}${OFF}\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a :
at the end of "Enclave ID", also below for "App ID".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, so it's usable for the workshop, but please fix the indentation soon, so the code doesn't turn into a mess again :D (I don't care what you use, as long as it's consistent for the entire file.)
Using 2 spaces now in throughout start.sh since this is already what we used in spinup-oasis-stack.sh. |
7737d4f
to
8f0d83a
Compare
This PR:
Fixes #603, #613
To start your ROFL, simply bind mount your folder containing the .orc file to the
/rofls
folder and it will spin it up automatically.For example: