Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Fallback sapphire-localnet to glibc #623

Merged
merged 1 commit into from
Sep 20, 2024
Merged

docker: Fallback sapphire-localnet to glibc #623

merged 1 commit into from
Sep 20, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Sep 20, 2024 •
edited
Loading

Workaround for #622

@matevz matevz force-pushed the matevz/fix/docker-musl-macos branch 2 times, most recently from 5036eb9 to 5fa4f70 Compare September 20, 2024 18:49
jberci
jberci approved these changes Sep 20, 2024
View reviewed changes
Copy link

@jberci jberci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to reproduce the original issue, but the changes produce a usable docker image on an M1 computer.

@matevz matevz merged commit c41077a into main Sep 20, 2024
6 checks passed
@matevz matevz deleted the matevz/fix/docker-musl-macos branch September 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberci jberci jberci approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @jberci