Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Viem documentation #225

Closed
wants to merge 2 commits into from
Closed

Add Viem documentation #225

wants to merge 2 commits into from

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Nov 17, 2023 •
edited
Loading

Description

Viem has changed a bit since when we opened #164. This snippet works with Viem examples.

TODO

@aefhm aefhm self-assigned this Nov 17, 2023
@aefhm aefhm added p:1 Priority: high js client labels Nov 17, 2023
@aefhm aefhm marked this pull request as ready for review November 17, 2023 21:15
@aefhm aefhm requested a review from matevz November 17, 2023 21:15
aefhm
aefhm commented Nov 17, 2023
View reviewed changes
clients/js/README.md
@@ -68,6 +68,44 @@ const provider = sapphire.wrap(window.ethereum);
window.ethereum = sapphire.wrap(window.ethereum); // If you're feeling bold.
```

### Viem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep or replicate these snippets to https://github.com/oasisprotocol/docs? Or is this okay for now? cc @matevz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I have my answer in oasisprotocol/docs#585

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CedarMist we probably want BOTH our npm user facing documentation as well as official documentation snippets right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the npm readme, the WAGMI part should go into https://docs.oasis.io/dapp/sapphire/browser and the Viem part into https://docs.oasis.io/dapp/sapphire/quickstart or perhaps https://docs.oasis.io/dapp/sapphire/guide.

btw. Does Viem support encrypted transactions using our wrapper? I thought we only integrate with ethers hooks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the npm readme, the WAGMI part should go into https://docs.oasis.io/dapp/sapphire/browser and the Viem part into https://docs.oasis.io/dapp/sapphire/quickstart or perhaps https://docs.oasis.io/dapp/sapphire/guide.

This sure is more convenient to reference on a PR now. 😉

Does Viem support encrypted transactions using our wrapper? I thought we only integrate with ethers hooks?

I'm able to get this through as opposed to unwrapped transaction, and I sampled these demo examples as working.

It is all EIP-1193 the way down with custom providers the way they wrap it.

@aefhm aefhm force-pushed the xz/add-viem-snippet branch 5 times, most recently from 8a251c8 to fe30a74 Compare December 2, 2023 02:16
@CedarMist CedarMist mentioned this pull request Mar 23, 2024
Closed
@aefhm
Copy link
Contributor Author

aefhm commented Jun 25, 2024

This is now fairly stale and provides less support #303.

@aefhm aefhm closed this Jun 25, 2024
@aefhm aefhm deleted the xz/add-viem-snippet branch June 25, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhynes nhynes nhynes approved these changes

@matevz matevz Awaiting requested review from matevz

Assignees

@aefhm aefhm

Labels
client p:1 Priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aefhm @matevz @nhynes