-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Foundry toolkit that enables Sapphire precompile and decryption #484
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder is dependencies/
still the right folder naming? I think forge
now only prefers lib/
, e.g. when you run forge install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both are still supported, soldeer uses dependencies
integrations/foundry/README.md
Outdated
- `DeoxysiiOpen`: Decrypt data using Deoxys-II | ||
- `Curve25519ComputePublic`: Compute public keys | ||
- `DECODE`: decode cbor encoded data and decrypt the calldata. | ||
<span style="color:red">Warning</span>: This precompile is not part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span style="color:red">Warning</span>: This precompile is not part of | |
**Warning:** This precompile is not part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming suggestions/questions.
examples/foundry/Makefile
Outdated
|
||
build: | ||
forge install foundry-rs/forge-std --no-commit --no-git | ||
forge soldeer install @oasisprotocol-sapphire-contracts~0.2.11 --config-location foundry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we simply put a dependencies/oasisprotocol-sapphire-contracts
symlink pointing to ../../../contracts
folder instead? This way we could always test whether sapphire contracts broke any foundry example specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integrations-foundry
folder should probably be named oasisprotocol-sapphire-foundry
to match the soldeer package, no (without the leading @
)?
|
||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
- Delegations | ||
- Undelegations | ||
- Receipt tracking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Delegations | |
- Undelegations | |
- Receipt tracking | |
- Delegations | |
- Undelegations | |
- Receipt tracking |
|
||
## List of precompiles | ||
|
||
### Cryptographic Operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line after the title should always be empty.
### Cryptographic Operations | |
### Cryptographic Operations | |
|
||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to oasisprotocol-sapphire-foundry
?
This PR:
Enables local testing of Sapphire-compatible contracts without using forks.