Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Use Q_OBJECT macro for BrowserDock #11785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

frontend: Use Q_OBJECT macro for BrowserDock #11785

wants to merge 1 commit into from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Jan 28, 2025

Description

This is needed as the BrowserDock is a QObject.

Motivation and Context

Without this, #11784 fails to compile

How Has This Been Tested?

Compiled and ran OBS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121
frontend: Use Q_OBJECT macro for BrowserDock
b487afd 
This is needed as the BrowserDock is a QObject.
@cg2121 cg2121 added Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels Jan 28, 2025
@cg2121 cg2121 mentioned this pull request Jan 28, 2025
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cg2121