Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-outputs: Allow enabling BPM for Hybrid MP4 output #11794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derrod
Copy link
Member

@derrod derrod commented Jan 30, 2025

Description

Adds an option to enable BPM (Broadcast Performance Metrics) for the Hybrid MP4 output.

Motivation and Context

BPM is quite useful to track performance over time, having it in a local file is a nice debugging option.

How Has This Been Tested?

Enabled it and checked BPM data is in output file.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the New Feature New feature or plugin label Feb 2, 2025
Copy link
Collaborator

@Lain-B Lain-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but what exactly made you think of doing this? Did something happen?

@derrod
Copy link
Member Author

derrod commented Feb 3, 2025

Seems fine, but what exactly made you think of doing this? Did something happen?

I just wanted to be able to get BPM data without needing to have a streaming output with it enabled. I also wanted to add this to the debug output option we have for multitrack so local files also include this info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants