Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced duplicated names in contributor list #1546

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lindaokorie27
Copy link

@lindaokorie27 lindaokorie27 commented Apr 20, 2021

Issue Description

The names in the contributors list are duplicated making the list very long

Fixes #1421

Changes Made

I checked the list using email addresses to make the search term more unique than using names

  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

Copy link

@gs0510 gs0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @LindieK! Were you able to check if the changes you made resulted in less duplications on the contributors.html page? Can you add a screenshot? Thanks!

@@ -44,7 +44,7 @@ The contributors to this site, extracted from the
[Git log](https://github.com/ocaml/ocaml.org/commits/master), are:

<ul id="contributors_list">
((! cmd git log --format="%aN" | sort | uniq | awk '{print "<li>"$1,$2,$3"</li>"}' !))
((! cmd git log --format="%aE %aN" | sort | uniq | awk '{print "<li>"$2,"</li>"}' !))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in printing only the first name of folks which isn't what we want. You want to list only the contributors using their email as a key for finding unique contributors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. Let me try again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gs0510 I have worked on it now. It displays contributor's full names. It removes names attached to the same email address. There are a lot of contributors though that have multiple email addresses.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LindieK you can look into how to find only the uniq names in the list so awk can print only them. :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for idea. I'll look into it right away

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted it further after the awk statement. The only thing left causing duplications is that the email and name documented on some commits are the person's github username (different from the full name used in other commit messages) and the auto-generated email from github that has the @users.noreply.gtihub.com extension.

Copy link

@gs0510 gs0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of duplicate names in contributors list
2 participants