feat(dlm): response the comments on #4151 #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LioRoger
reviewed
Feb 7, 2025
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionTesting.java
Outdated
Show resolved
Hide resolved
| @@ -36,6 +38,13 @@ public class DefaultConnectionAdapter implements ConnectionAdapter { | |||
| */ | |||
| public <T extends CloudConnectionConfig> T adaptConfig(T connectionConfig) { | |||
| PreConditions.notNull(connectionConfig, "connectionConfig"); | |||
| if (connectionConfig instanceof ConnectionConfig | |||
There was a problem hiding this comment.
type may be a common attribute for Connection config
LioRoger
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
What this PR does / why we need it:
Response the comments on #4151
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: